Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
  1. Global vs On-page Indication bug
    Global vs On-page indicators are not 100% accurate. If the CSS Prop is being used in the <template> instead of the CSS, for example in a component prop <component color="--ads-component-color"> then testing for use on the page will not get picked up by the parser and the indicator will imply the prop is not used on the page even though it is. This makes the indicator unreliable.

  2. Single app support per save file
    When saving, the exposed props in the app overwrite the save file. This means any props exposed in other apps using the same save file would be overwritten and therefore each app requires its own safe file and setup at this time.

  3. Vuetify Version Conflicts
    Theme designer uses Vuetify V3. Sep UI and NOP both use Vuetify 2. There are CSS differences between the two versions and they leak into eachother when TD is enabled. This causes some layout discrepancies in both the host app and in TD. Some have been resolved with using !important in the TD app, but some CSS issues remain unresolved until Sep-ui is on Vuetify 3.

  4. Prop inconsistency when Cloud Header styles are activated
    When a resort is on legacy but has the cloud header enabled, additional styles are inserted into the PLP that interfere with the ability of TD to fully style the page. These include editing the page background and editing the card container drop shadow. This in itself is not the issue, but rather that those props are still exposed and TD will generate the controls to adjust them but they will have no effect on the page. This is likely to cause confusion with users.

  5. Save file props are not adequately considered when scanning the CSS for exposed props
    When parsing all the page CSS imports, the JS builtin getPropertyValue() only evaluates prop values, not prop keys. So only prop keys that reference a custom --ads prop as its value get included. There is no equivalent getPropertyKey() built in method in JS to get property keys from a stylesheet.

    For example:

    This is a save file prop. --ads-card-header-primary-color: red;
    Because --ads-card-header-primary-color is only referenced as the key, not the value, it would not be included in the prop list.

    In the same save file, we might have:
    --ads-card-header-primary-color: var(--ads-card-text-color)
    In this case, --var-card-text-color would get included in the site prop list because it is a value, but --ads-card-header-primary-color would still not get included, because it is a key.

    This causes problems because this means we cannot rely on the save file to carry props over to another application unless those values are specifically used in the host applications CSS.